-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate #684
Consolidate #684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @akremstudy ! Awesome refactoring of the reporter. Huge. I has some minor suggestions. Some tests needed for the new cli commands. I'd also encourage posting some example txs using the new cli commands, as well as just reporting, just as a sanity check. Great cli additions and updates to gas fees calculation code!
Testing by running a reporter on each testnet listening for tips / reporting at regular intervals. I haven't tested every combination of flags, but no errors so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @akremstudy !
Summary
Made quite a few edits:
Steps Taken to QA Changes
Example transactions using cli:
Checklist
This pull request is:
<link to issue>
" in this Pull Request's summary section.<link to issue>
" in this Pull Request's summary section.Happy engineering!